Same comment regarding "vdev", here starting from the subject.

Also, this patch isn't purely cfg80211 - should probably split it into
cfg80211 and mac80211 parts?

On Mon, 2014-10-20 at 15:49 -0700, gree...@candelatech.com wrote:
> From: Ben Greear <gree...@candelatech.com>
> 
> This is useful when creating virtual-stations, and probably
> APs and other devices as well.

It clearly is - imho worth rephrasing as just "when creating virtual
interfaces" :-)

> +++ b/include/net/cfg80211.h
> @@ -319,9 +319,9 @@ struct ieee80211_supported_band {
>  /**
>   * struct vif_params - describes virtual interface parameters
>   * @use_4addr: use 4-address frames
> - * @macaddr: address to use for this virtual interface. This will only
> - *   be used for non-netdevice interfaces. If this parameter is set
> - *   to zero address the driver may determine the address as needed.
> + * @macaddr: address to use for this virtual interface.
> + *   If this parameter is set to zero address the driver may
> + *   determine the address as needed.


Maybe point to the feature flag here.

> + * @NL80211_FEATURE_MAC_ON_CREATE: Device supports configuring
> + *   the vdev's MAC address upon creation.

Maybe point to the attribute that's used for that here?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to