On Tue, Nov 4, 2014 at 2:53 PM, Otcheretianski, Andrei
<[email protected]> wrote:
> The spec doesn't require unlimited to be really "unlimited" and the AP 
> decides when to end the SP, so any value here is ok.
> However for large traffic bursts increasing this value looks reasonable. Also 
> looks like some certification tests expect more frames to be delivered during 
> SP.
> 128 is still kind of arbitrary value
>
>> -----Original Message-----
>> From: Krishna Chaitanya [mailto:[email protected]]
>> Sent: Tuesday, November 04, 2014 11:03
>> To: Grumbach, Emmanuel
>> Cc: Johannes Berg; linux-wireless; Otcheretianski, Andrei
>> Subject: Re: [PATCH] mac80211: Increase uapsd max SP frames number
>>
>> On Tue, Nov 4, 2014 at 2:10 PM, Emmanuel Grumbach
>> <[email protected]> wrote:
>> > From: Andrei Otcheretianski <[email protected]>
>> >
>> > Deliver up to 128 frames during SP instead of 8 if unlimited max SP is
>> > specified during association.
>> >
>> > Signed-off-by: Andrei Otcheretianski <[email protected]>
>> > Signed-off-by: Emmanuel Grumbach <[email protected]>
>> > ---
>> >  net/mac80211/sta_info.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index
>> > de494df..3352741 100644
>> > --- a/net/mac80211/sta_info.c
>> > +++ b/net/mac80211/sta_info.c
>> > @@ -1531,7 +1531,7 @@ void ieee80211_sta_ps_deliver_uapsd(struct
>> sta_info *sta)
>> >                 break;
>> >         case 0:
>> >                 /* XXX: what is a good value? */
>> > -               n_frames = 8;
>> > +               n_frames = 128;
>> >                 break;
>> >         }
>> What is criteria for deciding the threshold?
>> Any specific use case for 128?
I understand, thanks for the explanation.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to