Vladimir Kondratiev <[email protected]> writes:

> Introduce netdev IOCTLs, to be used by the debug tools.
>
> Allows to read/write single dword value or
> memory block, aligned to dword
> Different address modes supported:
> - BAR offset
> - Firmware "linker" address
> - target's AHB bus
>
> Signed-off-by: Vladimir Kondratiev <[email protected]>

An ioctl interface for a wireless driver? IMHO that would have been ok
in 2004, but not in 2014. Isn't there really better way to implement
this?

> +/* Numbers SIOCDEVPRIVATE and SIOCDEVPRIVATE + 1
> + * are used by Android devices to implement PNO (preferred network offload).
> + * Albeit it is temporary solution, use different numbers to avoid conflicts
> + */

Comments like this make me even more worried that that this is just yet
another way to implement wext iwpriv interface.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to