Michal Kazior <[email protected]> writes: >>> int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode) >>> { >>> int status; >>> @@ -939,6 +950,8 @@ int ath10k_core_start(struct ath10k *ar, enum >>> ath10k_firmware_mode mode) >>> else >>> ar->free_vdev_map = (1LL << TARGET_NUM_VDEVS) - 1; >>> >>> + ath10k_core_init_max_sta_count(ar); >> >> I don't see the need to call this during every firmware start as these >> are not changed afterwards. I think it would be better to call this once >> just after ath10k_core_fetch_firmware_files() is called. > > Hmm.. It makes sense but now that I think about it the max number of > peers should actually depend on WMI_SERVICE_IRAM_TIDS which is known > after booting firmware. However since only 10.x was released with the > service enabled we used fw_features. So..
I think this is good enough for now. We can always improve this later. > yeah. I can move the function call if you want though. Please do that. To keep things simple I would like to have the absolute minimum in start() calls. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
