Michal Kazior <[email protected]> writes:

> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
> @@ -1381,6 +1381,8 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k 
> *ar,
>  {
>       struct sk_buff *msdu;
>       struct htt_rx_desc *rxd;
> +     bool is_mgmt;
> +     bool has_fcs_err;
>  
>       msdu = skb_peek(amsdu);
>       rxd = (void *)msdu->data - sizeof(*rxd);
> @@ -1394,12 +1396,19 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k 
> *ar,
>               return false;
>       }
>  
> +     is_mgmt = !!(rxd->attention.flags &
> +                  __cpu_to_le32(RX_ATTENTION_FLAGS_MGMT_TYPE));
> +     has_fcs_err = !!(rxd->attention.flags &
> +                      __cpu_to_le32(RX_ATTENTION_FLAGS_FCS_ERR));

I think I asked this before in some other patch, but isn't '!!' operator
useless here? is_mgmt is a boolean so the compiler should convert it
correctly without '!!' anyway, right?

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to