Hi Arend,

> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> index 0f01fe0..61f8318 100644
> --- a/include/linux/mmc/sdio_ids.h
> +++ b/include/linux/mmc/sdio_ids.h
> @@ -29,6 +29,8 @@
> #define SDIO_DEVICE_ID_BROADCOM_4329          0x4329
> #define SDIO_DEVICE_ID_BROADCOM_4330          0x4330
> #define SDIO_DEVICE_ID_BROADCOM_4334          0x4334
> +#define SDIO_DEVICE_ID_BROADCOM_43340                43340
> +#define SDIO_DEVICE_ID_BROADCOM_43341                43341

the general preference is to have these values in hex. I get the fact that they 
map the marketing number, but that could be just stated in a comment after the 
hex number.

> #define SDIO_DEVICE_ID_BROADCOM_4335_4339     0x4335
> #define SDIO_DEVICE_ID_BROADCOM_43362         43362
> #define SDIO_DEVICE_ID_BROADCOM_4354          0x4354

Is there any chance that you can also send patches against sdio.ids database 
from systemd:

http://cgit.freedesktop.org/systemd/systemd/tree/hwdb/sdio.ids

That would allow for udev to provide friendly names and they would also be 
shown using networkctl.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to