Am 24.01.2015 um 11:33 schrieb Sedat Dilek: > On Sat, Jan 24, 2015 at 11:23 AM, Kalle Valo <[email protected]> wrote: >> Hong Xu <[email protected]> writes: >> >>> ath9k and ath9k_htc use the variable name "led_blink" to indicate >>> whether the module parameter "blink" is on. This name is easy to >>> conflict with other variables, thus they are renamed. >> >> Please state clearly that this fixes a compiler error found by kbuild. >> Also it's very much recommended to add the actual compiler error to the >> commit log: >> >> drivers/net/wireless/ath/ath9k/ath9k_htc.o:(.data+0x47c): multiple >> definition of `led_blink' >> drivers/net/wireless/ath/ath9k/ath9k.o:(.bss+0x20): first defined here >> > > Some more things... > > If you post a vN (referring to your v3) of a patch, please add a > history of changes.
What kind of history do you wont to have here? Kernel log should not be
overloaded with patch preparation history.
> 2nd, use the Fixes tag [2] in this case with a reference to the
> culprit commit [1].
>
> Fixes: 3a939a671225 ("ath9k_htc: Add a module parameter to disable blink")
>
> Last but not least, honour credits like Reported-by/Tested-by (plus
> some infos like broken in Linux-next $VERSION).
>
> - Sedat -
>
> [1]
> http://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=3a939a671225909c19b09bfcb6e4761109e913d9
> [2]
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n159
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Regards,
Oleksij
signature.asc
Description: OpenPGP digital signature
