Sedat Dilek <[email protected]> writes: > On Sat, Jan 24, 2015 at 12:34 PM, Hong Xu <[email protected]> wrote: >> ath9k and ath9k_htc use the variable name "led_blink" to indicate >> whether the module parameter "blink" is on. This name is easy to >> conflict with other variables, and has caused a compiler error found >> by kbuild test bot. The compiler error is as following: >> >> drivers/net/wireless/ath/ath9k/ath9k_htc.o:(.data+0x47c): multiple >> definition of `led_blink' >> drivers/net/wireless/ath/ath9k/ath9k.o:(.bss+0x20): first defined here >> >> Fixes: 3a939a671225 ("ath9k_htc: Add a module parameter to disable blink") >> Reported-by: kbuild test robot <[email protected]> >> Signed-off-by: Hong Xu <[email protected]> >> --- >> Compared to previous versions, the commit message is improved to fit >> the contribution guideline (again). >> --- > > This looks good.
Indeed. > I have one thing for followers of (linux-wireless) mailing-lists in > general. If your patch is against a special Git tree, please add a > "subject-prefix" and/or put a note in the commit-body. For example: > "This patch is against wireless-drivers-next or linux-next > (next-2015-01-23)." This is very helpful. I don't think that's necessary as by default driver patches go to wireless-drivers-next. But if the patch should go to an -rc release for whatever (good) reasons it's best to mark the patch like "[PATCH 3.19]" or similar, that way I can easily see that it should go to 3.19. Larry does that and it's really helpful. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
