On 26 January 2015 at 10:49, Janusz Dziedzic <[email protected]> wrote: > On 26 January 2015 at 10:25, Johannes Berg <[email protected]> wrote: >> On Mon, 2015-01-26 at 10:19 +0100, Janusz Dziedzic wrote: >>> On 26 January 2015 at 10:00, Johannes Berg <[email protected]> >>> wrote: >>> > On Mon, 2015-01-26 at 10:37 +0200, Arik Nemtsov wrote: >>> > >>> >> >> Shouldn't you also set vht_oper->basic_mcs_set here? Of course if you >>> >> >> have no use for it in IBSS I can add it later. >>> >> > >>> >> > Why would you want to require VHT rates? >>> >> >>> >> Are you sure it's required and no the other way around in this case? >>> >> As in specifying which rates are not supported. >>> >> Not sure it means the same thing as in the HT instance. >>> > >>> > Well, it does mean the same thing ("these rates are required") but it's >>> > encoded in a way that you have to set it to all-ones (rather than >>> > all-zeroes) to mean "no requirements", so in that sense you're right. >>> > >>> >>> I already set this in the patch: >>> + vht_oper->basic_mcs_set = vht_cap->vht_mcs.rx_mcs_map; >> >> But do you really want to require the local capabilities as basic MCSes? >> > I am not sure. Will check spec and how we do that for an AP. > The Basic VHT-MCS and NSS Set field indicates the VHT-MCSs for each number of spatial streams in VHT PPDUs that are supported by all VHT STAs in the BSS (including IBSS and MBSS).
hostapd set this as: 0xfffc - 1 stream, MCS0-7 as a min Basic VHT MCS rates - this seems to be secure. BR Janusz -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
