On 2 March 2015 at 12:28, Vasanthakumar Thiagarajan <[email protected]> wrote: [...] > +static bool ath10k_mac_should_disable_promisc(struct ath10k *ar) > +{ > + struct ath10k_vif *arvif; > + > + if (!(ar->filter_flags & FIF_PROMISC_IN_BSS)) > + return true; > + > + if (!ar->num_started_vdevs) > + return false; > + > + list_for_each_entry(arvif, &ar->arvifs, list) > + if (arvif->vdev_type != WMI_VDEV_TYPE_AP) > + return false; > + > + ath10k_dbg(ar, ATH10K_DBG_MAC, > + "mac disabling promiscuous mode because vdev is > started\n"); > + ar->filter_flags &= ~FIF_PROMISC_IN_BSS;
ar->filter_flags shouldn't be changed. Especially in a function which shouldn't have side-effects. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
