On 04 Mar 2015 20:53, Johannes Berg wrote:
> On Wed, 2015-03-04 at 14:51 -0500, Mike Frysinger wrote:
> > From: Mike Frysinger <[email protected]>
> > 
> > Forcing -Werror at build time easily breaks across compiler settings,
> > compiler versions, architectures, C libraries, etc...  Add a knob so
> > distro peeps can turn it off.
> 
> > +WERROR = -Werror
> 
> Doesn't that need ?= ?

yes, if you wanted to support:
        WERROR= make

but the expectation is that you'd do:
        make WERROR=

in which case this code is working as i intended.  if the maintainers want to 
use ?= then it doesn't matter to me.
-mike

Attachment: signature.asc
Description: Digital signature

Reply via email to