Huh, why dropping linux-wireless (and top posting btw)? Please let everyone follow the discussion :)
On 15 April 2015 at 21:20, Hante Meuleman <[email protected]> wrote: > As I wrote to you in a mail and on the openwrt forum, this patch is indeed an > attempt to support more complex nvram files. I also wrote, that in order to > be able to use it, the nvram contents of the device (r8000) needs to be put a > specific file. Now for your concerns, we can perhaps add something which will > read the nvram contents directly from an nvram store. But that is irrelevant > to this patch. The parsing is still needed, and all we would need to add is > something which is reading the nvram contents from some other place So it makes me wonder if we need this patch in its current form. I think getting NVRAM directly from the platform is much user friendly. It doesn't require user to install some extra tools for dumping NVRAM and putting it in a specific file. One extra layer less. With that said I think it's hard to review your code for parsing NVRAM. We don't know how it's going to be fetched in the first place. > though it would have to be put under some kernel config flag as this would > not be supported in non-router systems. The contents of the nvram would > however still need to be parsed in exactly the same way as the nvram files we > read from disk. Again, it's hard to say for me. Are you going to use bcm47xx_nvram_getenv? Are you going to use MTD subsystem? Are you going to develop different solution? When using e.g. bcm47xx_nvram_getenv you won't want all this parsing stuff at all. It seems this patch provides some end-support for NVRAM parsing while we still miss something between. Something for getting NVRAM from platform and providing it to the brcmfmac somehow. > As to your concern regarding pci/ versus pcie/: pci/ is old type and will > never be used/supported by brcmfmac. All new routers will use either the > compressed format like the r8000 does or the pcie/ (uncompressed) format > depending on the size of the nvram store. Oh, I didn't notice that. OK, thanks for pointing this. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
