Hi Johannes, Minor nit:
On Wed, Jun 3, 2015 at 5:39 AM, Johannes Berg <[email protected]> wrote: > From: Johannes Berg <[email protected]> > > As we're running out of hardware capability flags pretty quickly, > convert them to use the regular test_bit() style unsigned long > bitmaps. > > This introduces a number of helper functions/macros to set and to > test the bits, along with new debugfs code. > > Signed-off-by: Johannes Berg <[email protected]> > --- > diff --git a/include/net/mac80211.h b/include/net/mac80211.h > index e09a32cb139f..dc56734d0154 100644 > --- a/include/net/mac80211.h > +++ b/include/net/mac80211.h > @@ -2050,6 +2053,20 @@ struct ieee80211_hw { > int txq_ac_max_pending; > }; > > +static inline bool _ieee80211_hw_check(struct ieee80211_hw *hw, > + enum ieee80211_hw_flags flg) > +{ > + return test_bit(flg, hw->flags); > +} > +#define ieee80211_hw_check(hw, flg) _ieee80211_hw_check(hw, > IEEE80211_HW_##flg) > + > +static inline void _ieee80211_hw_set(struct ieee80211_hw *hw, > + enum ieee80211_hw_flags flg) > +{ > + return __set_bit(flg, hw->flags); > +} > +#define ieee80211_hw_set(hw, flg) _ieee80211_hw_set(hw, > IEEE80211_HW_##flg) > + Why not add a ieee80211_hw_clear() function? Yes, it'd only be used in 3 places, but it'd look neater. Thanks, -- Julian Calaby Email: [email protected] Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
