+patch author > - if (retry->disabled || > + if (retry->disabled || retry->value < 1 || retry->value > 255 || > (retry->flags & IW_RETRY_TYPE) != IW_RETRY_LIMIT) > return -EINVAL; > > > > I'm wondering, is the 'retry->value < 1' is necessary? I would write > 'retry->value < 0' instead, to make possible to disable the retries. > Should I send a patch?
I think this is likely some confusion over what "retry" means. Some places in the code used to take it as "# of transmission attempts", others (imho more correctly) interpret it as "# of retries". I think it's probably fine to change to < 0. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
