Resubmitting as v2 due to mangled white spaces.
On Mon, Jun 8, 2015 at 10:28 AM, Jesse Jones <[email protected]> wrote: > I took a look at the spec too and also didn't see mention of the MP_F_RF > flag. Section 13.10.9.3 for example talks about PREQ handling and in case E2 > talks about sending replies back. It says to do that if target only is not > set which makes sense: MP_F_RF and MP_F_DO are exclusive options so it's > silly to use two different flags for them. > > But for the purposes of this patch that is a moot issue: the semantics of > the function don't change and the original code was both confusing and using > the wrong value for metric for the not target only, intermediate station > case. > > -- Jesse > > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Yeoh Chun-Yeow > Sent: Monday, June 08, 2015 1:55 AM > To: [email protected] > Subject: Re: [PATCH] mac80211: Fix a case of incorrect metric used when > forwarding a PREQ > > As mentioned in Section 13.10.9.3 Case E2, the PREQ forwarding should use > metric "as received + own metric toward transmitter of received PREQ". So > you are right. > > Just MP_F_RF bit is no longer use. After replying with PREP, forwarding the > PREQ by setting the IEEE80211_PREQ_TO_FLAG in the per target flags. > > --- > Chun-Yeow > > On Mon, Jun 8, 2015 at 4:07 PM, Yeoh Chun-Yeow <[email protected]> > wrote: >> Hi, Alexis Green >> >> I just take a look back on the code before implementing the Proactive >> PREQ for PREP. For the case of reply and forward (target_flags & >> MP_F_RF), the previous metric used is the one which resolved from >> mpath->metric. >> >> Refer here: >> https://github.com/o11s/open80211s/blob/o11s-0.4.2/net/mac80211/mesh_h >> wmp.c >> >> But to say that, I cannpt confirm whether this is correct. The >> standard 802.11-2012 has no longer specified bit-1 MP_F_RF (Refer >> section 8.4.2.115 per target flag). So maybe it is not relevant >> anymore. We may need to remove as well. >> >> ---- >> Chun-Yeow > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to [email protected] More majordomo info at > http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
