On Thu, 2015-07-02 at 10:45 -0400, Bob Copeland wrote: > On Thu, Jul 02, 2015 at 03:31:38PM +0200, Johannes Berg wrote: > > On Thu, 2015-07-02 at 09:28 -0400, Bob Copeland wrote: > > > > > > + DECLARE_BITMAP(aid_map, IEEE80211_MAX_AID + 1); > > > > > Is there really much point in keeping a long-lived bitmap rather > > than > > iterating the existing stations when adding a new one? It's not > > such a > > frequent operation after all. > > Not really -- I tried it both ways initially, and the bitmap ended up > with less code and u.mesh was still (slightly) smaller than u.mgd, > but I agree it does feel kind of bloaty so I'll prep a version the > other way.
I was less worried about the bloat part than the "we're maintaining this data twice" and corruptions/missing some remove paths etc. That doesn't seem very likely though since it goes through the common alloc/destroy path, so I guess it's not a problem. Whichever you prefer really, I don't really mind. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
