Regarding this commit:
https://lkml.org/lkml/2014/12/12/709
rsi: fix memory leak in rsi_load_ta_instructions()
Memory allocated by kmemdup() in rsi_load_ta_instructions() is leaked.
But duplication of firmware data here is useless,
so the patch removes kmemdup() at all.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <[email protected]>
Signed-off-by: Kalle Valo <[email protected]>
We use this driver for the Redpine Wifi chip on our "florida" board, and after
this commit it stopped working. Symptom was that the "wlan0" device was not
created at all. Reverting the commit makes it work again.
Apparently, the kmemdup action is needed for something. I suspect the DMA
controller is still copying the firmware data before the method returned.
Having no experience with this part of the kernel, I wasn't able to come up
with a more constructive solution than just reverting the patch.
Kind regards,
Mike Looijmans.
Kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
Telefax: +31 (0) 499 33 69 70
E-mail: [email protected]
Website: www.topicproducts.com
Please consider the environment before printing this e-mail
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
