From: pkshih <[email protected]>

There is a potential race condition when the control byte of a CAM entry
is written first.

Signed-off-by: pkshih <[email protected]>
Signed-off-by: shaofu <[email protected]>
Signed-off-by: Larry Finger <[email protected]>
---
 drivers/net/wireless/rtlwifi/cam.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rtlwifi/cam.c 
b/drivers/net/wireless/rtlwifi/cam.c
index 8fe8b4c..cc7acbf 100644
--- a/drivers/net/wireless/rtlwifi/cam.c
+++ b/drivers/net/wireless/rtlwifi/cam.c
@@ -45,12 +45,13 @@ static void rtl_cam_program_entry(struct ieee80211_hw *hw, 
u32 entry_no,
 
        u32 target_command;
        u32 target_content = 0;
-       u8 entry_i;
+       s8 entry_i;
 
        RT_PRINT_DATA(rtlpriv, COMP_SEC, DBG_DMESG, "Key content :",
                      key_cont_128, 16);
 
-       for (entry_i = 0; entry_i < CAM_CONTENT_COUNT; entry_i++) {
+       /* 2-5 fill 128key,6-7 are reserved */
+       for (entry_i = CAM_CONTENT_COUNT - 3; entry_i >= 0; entry_i--) {
                target_command = entry_i + CAM_CONTENT_COUNT * entry_no;
                target_command = target_command | BIT(31) | BIT(16);
 
@@ -62,6 +63,7 @@ static void rtl_cam_program_entry(struct ieee80211_hw *hw, 
u32 entry_no,
                                        target_content);
                        rtl_write_dword(rtlpriv, rtlpriv->cfg->maps[RWCAM],
                                        target_command);
+                       udelay(100);
 
                        RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
                                 "WRITE %x: %x\n",
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to