Arend van Spriel <[email protected]> writes: > On 10/12/2015 10:59 AM, Kalle Valo wrote: >> kbuild test robot <[email protected]> writes: >> >>> Hi Arend, >>> >>> [auto build test ERROR on next-20151008 -- if it's inappropriate base, >>> please ignore] >>> >>> config: x86_64-randconfig-x011-201540 (attached as .config) >>> reproduce: >>> # save the attached .config to linux build tree >>> make ARCH=x86_64 >>> >>> All errors (new ones prefixed by >>): >>> >>> drivers/net/wireless/brcm80211/brcmfmac/debug.c:58:6: error: >>> redefinition of 'brcmf_debugfs_init' >>> void brcmf_debugfs_init(void) >>> ^ >>> In file included from >>> drivers/net/wireless/brcm80211/brcmfmac/bus.h:20:0, >>> from >>> drivers/net/wireless/brcm80211/brcmfmac/debug.c:24: >>> drivers/net/wireless/brcm80211/brcmfmac/debug.h:118:20: note: previous >>> definition of 'brcmf_debugfs_init' was here >>> static inline void brcmf_debugfs_init(void) >>> ^ >> >> Arend, are the kbuild errors valid? I would guess they are as >> wireless-drivers-next should be in linux-next. > > Actually they are not. I am not sure about the build infrastructure, > but the errors above can only occur when CONFIG_BRCMDBG is set, but > DEBUG is not. However, that can not happen as we have following line > in drivers/net/wireless/brcm80211/Makefile: > > subdir-ccflags-$(CONFIG_BRCMDBG) += -DDEBUG
I didn't check the details but I'm still not convinced :) In my opinion the code should always compile, with and without -DDEBUG. Anyways, I pushed this script to the pending branch to get kbuild test this patch once again. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
