Jakub Sitnicki <[email protected]> writes: > rtl8723au driver treats REG_9346CR register as either 8- or 16-bit wide, > while rtl8192cu driver treats it as 8-bit wide, and so does rtl8188eu > driver. Use the lowest common denominator strategy. > > Signed-off-by: Jakub Sitnicki <[email protected]> > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)
NACK - this is a 16 bit register and the vendor drivers take the lazy approach of just reading/writing the lower 8 bits when they feel like it. My code is more consistent, so this one is not going in. Jes > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c > b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c > index 11fcfda..5f90261 100644 > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c > @@ -1928,10 +1928,10 @@ static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv > *priv) > u16 val16, efuse_addr, offset; > u32 val32; > > - val16 = rtl8xxxu_read16(priv, REG_9346CR); > - if (val16 & EEPROM_ENABLE) > + val8 = rtl8xxxu_read8(priv, REG_9346CR); > + if (val8 & EEPROM_ENABLE) > priv->has_eeprom = 1; > - if (val16 & EEPROM_BOOT) > + if (val8 & EEPROM_BOOT) > priv->boot_eeprom = 1; > > val32 = rtl8xxxu_read32(priv, REG_EFUSE_TEST); -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
