On 12/18/2015 07:27 AM, Rafał Miłecki wrote: > I'm afraid it wasn't tested on BCM47XX (MIPS) :(
Yes, you are probably right. > On 14 August 2015 at 00:21, Hauke Mehrtens <ha...@hauke-m.de> wrote: >> @@ -218,9 +187,8 @@ int bcma_gpio_init(struct bcma_drv_cc *cc) >> chip->set = bcma_gpio_set_value; >> chip->direction_input = bcma_gpio_direction_input; >> chip->direction_output = bcma_gpio_direction_output; >> -#if IS_BUILTIN(CONFIG_BCM47XX) || IS_BUILTIN(CONFIG_ARCH_BCM_5301X) >> - chip->to_irq = bcma_gpio_to_irq; >> -#endif >> + chip->owner = THIS_MODULE; >> + chip->dev = bcma_bus_get_host_dev(bus); > > This assigns &bus->host_pdev->dev which is NULL. hmm, how do we fix this, as long as bcma does not have a device on mips this is a problem. Should we create a new device for mips? >> @@ -248,13 +216,13 @@ int bcma_gpio_init(struct bcma_drv_cc *cc) >> else >> chip->base = -1; >> >> - err = bcma_gpio_irq_domain_init(cc); >> + err = gpiochip_add(chip); >> if (err) >> return err; >> >> - err = gpiochip_add(chip); >> + err = bcma_gpio_irq_init(cc); > > This results in: > [ 0.157054] missing gpiochip .dev parent pointer > (coming from gpiochip_irqchip_add) and > [ 0.157287] bcma: bus0: Error registering GPIO driver: -22 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
