On Mon, Dec 21, 2015 at 9:53 AM, Larry Finger <[email protected]> wrote: > On 12/20/2015 08:28 PM, Dan Lenski wrote: >> >> Signed-off-by: Dan Lenski <[email protected]> > > > The commit message should be in this patch rather than in the non-patch > previous mail. If this patch were to be accepted, all that explanation would > be lost! > > Rather than issuing a warning when the MAC is changed after the interface > has been brought up, have you considered changing the value of > rtw_adapter->bup to zero whenever the connection goes down? Would that help > with the confusion in the user-space tools?
No. rtw_adapter isn't visible to userspace at all. NetworkManager, for instance, seems to get confused when *any* up interface changes its MAC address. bup should *not* be reset to zero when the device is closed. netdev_open23a() checks or bup==0 and calls rtl8723au_hal_init() to do hw initialization and firmware download if so. This is unnecessary after subsequent re-opening, which is why netdev_close() doesn't set bup=0. > NACK. I'll resubmit with the commit message fixed and the warning removed. Dan -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
