"Coelho, Luciano" <[email protected]> writes: > On Fri, 2016-03-04 at 19:53 +0100, Bjørn Mork wrote: > >> Still think it's unwise to leave ERR_PTR's around though. > > The main point is that we don't want to fail the entire driver loading > if the thermal zone (or cooling device) registration fails. We have a > fallback for that, which is what was used before this new > implementation (namely, the thermal throttling code in the driver).
Sure. I just think it is cleaner to replace the ERR_PTR with NULL before returning. Minor nit of course. I wouldn't have bothered with it if I hadn't wrongly thought that it would crash, Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
