On Sun, Mar 6, 2016 at 5:58 PM, Jouni Malinen <[email protected]> wrote:
>
> On Wed, Mar 02, 2016 at 11:28:31PM +0200, Emmanuel Grumbach wrote:
> > Even if the current chandef width is equal to the station's max-BW, it
> > doesn't mean it's a valid width for TDLS. Make sure to always check
> > regulatory constraints in these cases.
>
> I'm not sure this change is the trigger for this issue, but since I
> noticed this for the first time today and this commit went just in into
> wireless-testing.git, it sounds quite likely that this was indeed behind
> the busy loop I saw here:
>
> > diff --git a/net/mac80211/tdls.c b/net/mac80211/tdls.c
> > @@ -332,7 +332,7 @@ ieee80211_tdls_chandef_vht_upgrade(struct 
> > ieee80211_sub_if_data *sdata,
> >       /* proceed to downgrade the chandef until usable or the same */
> > -     while (uc.width > max_width &&
> > +     while (uc.width > max_width ||
> >              !cfg80211_reg_can_beacon_relax(sdata->local->hw.wiphy, &uc,
> >                                             sdata->wdev.iftype))
> >               ieee80211_chandef_downgrade(&uc);

Good catch :)
We actually just noticed this as well and have a suggested fix already
- basically the code was trying to *upgrade* a 80p80 channel to a 80
one.

I guess it will be out in a couple days after some internal testing.

Arik
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to