From: Ben Greear <[email protected]> By default, the rhashtable logic will fail to insert objects if the key-chains are too long and un-balanced.
In the degenerate case where mac80211 is creating many station vdevs connected to the same peer, this case can be hit. So, set insecure_elasticity to true to allow chains to grow as long as needed. Signed-off-by: Ben Greear <[email protected]> --- net/mac80211/sta_info.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index 38ef0be..c25b945 100644 --- a/net/mac80211/sta_info.c +++ b/net/mac80211/sta_info.c @@ -66,6 +66,7 @@ static const struct rhashtable_params sta_rht_params = { .nelem_hint = 3, /* start small */ + .insecure_elasticity = true, /* Disable chain-length checks. */ .automatic_shrinking = true, .head_offset = offsetof(struct sta_info, hash_node), .key_offset = offsetof(struct sta_info, addr), @@ -322,8 +323,11 @@ static int sta_info_hash_add(struct ieee80211_local *local, rv = rhashtable_insert_fast(&local->sta_hash, &sta->hash_node, sta_rht_params); - if (rv != 0) + if (rv != 0) { + pr_err("Failed to insert sta %pM in rhashtable, idx: %d err: %d\n", + sta->sta.addr, idx, rv); return rv; + } sta->vnext = sta->sdata->sta_vhash[idx]; rcu_assign_pointer(sta->sdata->sta_vhash[idx], sta); -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
