On Thu, 2016-04-07 at 15:04 +0000, Haim, Maya wrote:
> On 4/6/2016 10:19 AM, Joe Perches wrote:
> > On Tue, 2016-04-05 at 14:24 +0300, Maya Erez wrote:
> > > Add __func__ to all wil log macros for easier debugging.
> > I think this is unnecessary and merely bloats code size.
> > For all the _dbg calls, dynamic debug can add function names if
> > desired.
> >
> > If really desired, I suggest changing the logging functions to use
> > "%ps and __builtin_return_address(0)
[]
> implemented it with __builtin_return_address(0) at first but found its
> format less readable (e.g. wil_start_xmit+0x58/0x7e8).
> I agree that using __builtin_return_address(0) simplifies the code and I'm OK
> with your suggestion to use it.
I believe you must have used %pS and not %ps
See: Documentation/printk-formats.txt
Symbols/Function Pointers:
%pS versatile_init+0x0/0x110
%ps versatile_init
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
