> Doesn't this have to check that it actually got information for the right > band? Hi Johannes , nl80211_parse_tx_bitrate_mask ( a new wrapper to the existing functionality in nl80211_set_tx_bitrate_mask ) does this , isn't ?
Regards, Sunil -----Original Message----- From: Johannes Berg [mailto:[email protected]] Sent: Friday, August 5, 2016 2:33 PM To: Kushwaha, Purushottam <[email protected]> Cc: [email protected]; Malinen, Jouni <[email protected]>; Undekari, Sunil Dutt <[email protected]>; Kondabattini, Ganesh <[email protected]>; Kalikot Veetil, Mahesh Kumar <[email protected]>; Hullur Subramanyam, Amarnath <[email protected]> Subject: Re: [PATCH] cfg80211: Add support for user configurable beacon data rate On Fri, 2016-08-05 at 10:05 +0530, Purushottam Kushwaha wrote: > > +static int nl80211_parse_tx_bitrate_mask(struct genl_info *info, > + struct cfg80211_bitrate_mask *mask); I think you should move the function instead. > @@ -3457,6 +3459,11 @@ static int nl80211_start_ap(struct sk_buff > *skb, struct genl_info *info) > err = cfg80211_validate_beacon_int(rdev, > params.beacon_interval); > if (err) > return err; > + if (info->attrs[NL80211_ATTR_TX_RATES]) { > + err = nl80211_parse_tx_bitrate_mask(info, > ¶ms.beacon_rate); > + if (err) > + return err; > + } Doesn't this have to check that it actually got information for the right band? johannes N�����r��y����b�X��ǧv�^�){.n�+����{��*ޕ�,�{ay� ʇڙ�,j��f���h���z� �w��� ���j:+v���w�j�m��������zZ+�����ݢj"��!�i
