Johannes Berg <[email protected]> writes: >> > > +static int invoke_tx_handlers(struct ieee80211_tx_data *tx) >> > > +{ >> > > + return invoke_tx_handlers_early(tx) || >> > > invoke_tx_handlers_late(tx); >> > > +} >> > >> > Ugh, please, no, don't be tricky where it's not necessary. Now >> > every >> > person reading this has to first look up the return type, and then >> > the >> > return value, and make sure they understand that success is >> > actually >> > the value 0 ... that's way too much to ask. >> >> Noted. Any objections to turning these into bool return types? > > They have three possible values ... :)
Ah, no, not the handlers themselves. Meant the invoke_tx_handlers() function (or all three of them after my patch; hence the plural). To avoid the "0 means true" confusion you alluded to :) -Toke
