Kalle Valo <kv...@codeaurora.org> writes: > Baoyou Xie <baoyou....@linaro.org> wrote: >> We get 1 warning about global functions without a declaration >> in the rtl8xxxu rtl8xxxu_core.c when building with W=1: >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: >> warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd' >> [-Wmissing-prototypes] >> >> In fact, this function is only used in the file in which it is declared >> and don't need a declaration, but can be made static. >> so this patch marks it 'static'. >> >> Signed-off-by: Baoyou Xie <baoyou....@linaro.org> > > The title should be "rtl8xxxu: ". See: > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name > > Also I assume Jes will take this.
Yes to both accounts! Thanks, Jes
