Arend Van Spriel <arend.vanspr...@broadcom.com> writes: > On 8-9-2016 7:36, Prameela Rani Garnepudi wrote: >> From: Prameela Rani Garnepudi <prameela.garnep...@redpinesignals.com> > > Seems like you missed the essential training on main-line driver > development :-p > > Typically you should split this up in conceptually separate patches so > it is easier for people to review. A large patch changing things all > over the place solving different things is taking a lot more time to review. > > So go work on branch, make a commit for each issue you want to address, > and when ready do (using 6 commits as example): > > $ git format-patch -s -M --cover-letter -6 > > The '--cover-letter' results in 0000-...patch file in which you can > summarize the changes in bullet list so Kalle can reuse that moving the > patches upstream to networking subsystem. > > When done use git to send the patches: > > $ git send-email --to='Kalle Valo <kv...@codeaurora.org>' > --cc=linux-wireless@vger.kernel.org *.patch
And write a commit log for each patch. In minimum the commit log should answer to the question "Why?". A good way to learn how the this all works is to see how others do it. For example, you can see all ath9k commits like this: gitk drivers/net/wireless/ath/ath9k/ or iwlwifi: gitk drivers/net/wireless/intel/iwlwifi/ -- Kalle Valo
