Rajat Jain <[email protected]> writes: > Hello Kalie, > > On Mon, Oct 3, 2016 at 6:04 AM, Kalle Valo <[email protected]> wrote: >> Rajat Jain <[email protected]> wrote: >>> Enable notifying wakeup source to the PM core in case of >>> a wake on wireless LAN event. >>> >>> Signed-off-by: Wei-Ning Huang <[email protected]> >>> Signed-off-by: Rajat Jain <[email protected]> >>> Tested-by: Wei-Ning Huang <[email protected]> >>> Reviewed-by: Eric Caruso <[email protected]> >>> Acked-by: Amitkumar Karwar <[email protected]> >> >> The commit log doesn't give any background info. Does this fix a bug or >> why is it needed? > > Some of chromeos' features (called "darkresume" in chromeos > terminology) use and track the wake up sources using the wakeup > attributes in sysfs. Since the wireless device can wake up the host, > hence we wanted to add it as a wakeup source to the system, and in the > case of an actual wakeup event, trigger to the PM core that it was > indeed caused by the device and it increments the different counters > etc. In the absence of this patch, the feature wasn't working very > well (as it was apparently confused about the cause of wake up).
Thanks, makes sense. Please add that to the commit and send v3. -- Kalle Valo
