to_pci_dev() would just do struct offset arithmetic on struct
device to get 'pdev' pointer. We never get NULL pdev pointer

Signed-off-by: Amitkumar Karwar <akar...@marvell.com>
---
New patch prepared as per inputs from Brian Norris.
It wasn't part of v1 and v2 series
---
 drivers/net/wireless/marvell/mwifiex/pcie.c | 22 ++++++----------------
 1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c 
b/drivers/net/wireless/marvell/mwifiex/pcie.c
index ba9e068..1e27dbf 100644
--- a/drivers/net/wireless/marvell/mwifiex/pcie.c
+++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
@@ -120,14 +120,9 @@ static int mwifiex_pcie_suspend(struct device *dev)
        struct pcie_service_card *card;
        struct pci_dev *pdev = to_pci_dev(dev);
 
-       if (pdev) {
-               card = pci_get_drvdata(pdev);
-               if (!card || !card->adapter) {
-                       pr_err("Card or adapter structure is not valid\n");
-                       return 0;
-               }
-       } else {
-               pr_err("PCIE device is not specified\n");
+       card = pci_get_drvdata(pdev);
+       if (!card || !card->adapter) {
+               pr_err("Card or adapter structure is not valid\n");
                return 0;
        }
 
@@ -164,14 +159,9 @@ static int mwifiex_pcie_resume(struct device *dev)
        struct pcie_service_card *card;
        struct pci_dev *pdev = to_pci_dev(dev);
 
-       if (pdev) {
-               card = pci_get_drvdata(pdev);
-               if (!card || !card->adapter) {
-                       pr_err("Card or adapter structure is not valid\n");
-                       return 0;
-               }
-       } else {
-               pr_err("PCIE device is not specified\n");
+       card = pci_get_drvdata(pdev);
+       if (!card || !card->adapter) {
+               pr_err("Card or adapter structure is not valid\n");
                return 0;
        }
 
-- 
1.9.1

Reply via email to