Prameela Rani Garnepudi <prameela.j0...@gmail.com> writes:

> added vap status(add/delete) field in vap capabilities frame to device
> added sending vap capabilites frame(with vap status 'delete') in remove 
> interface
>
> Signed-off-by: Prameela Rani Garnepudi <prameela.j0...@gmail.com>

Why? How is this better now? I'm sure there is a good reason why you add
this but we don't know as the commit tells nothing we don't already know
just from looking at the patch.

The most important part of commit log is to answer the question "Why?",
not "What?".

>               rsi_dbg(ERR_ZONE,
> -                     "%s: Interface type %d not supported\n", __func__,
> -                     vif->type);
> +                     "%s: Interface type %d not supported\n",
> +                     __func__, vif->type);

Unnecessary style change, please drop.

> -     rsi_dbg(MGMT_TX_ZONE, "%s: Sending VAP capabilities frame\n", __func__);
> +     rsi_dbg(MGMT_TX_ZONE,
> +             "%s: Sending VAP capabilities frame\n", __func__);

Same here.

-- 
Kalle Valo

Reply via email to