I think this looks good now. I'd prefer, however, doing the reorg that
gets rid of the memcpy() separately, that's now more or less orthogonal
to the changes you're making. I suspect it's due to you having just
edited the original, rather than starting from scratch, but I think it
makes sense to split it.

> +     memcpy(amsdu_hdr->h_source, h_80211_src, ETH_ALEN);
> +     memcpy(amsdu_hdr->h_dest, h_80211_dst, ETH_ALEN);

ether_addr_copy()? Alignment should be OK here.


Reply via email to