> - dev_coredumpm(mvm->trans->dev, THIS_MODULE, fw_error_dump,
> 0,
> - GFP_KERNEL, iwl_mvm_read_coredump,
> iwl_mvm_free_coredump);
> + sg_dump_data = alloc_sgtable(file_len);
> + if (sg_dump_data) {
> + sg_pcopy_from_buffer(sg_dump_data,
> + sg_nents(sg_dump_data),
> + fw_error_dump->op_mode_ptr,
> + fw_error_dump->op_mode_len, 0);
> + sg_pcopy_from_buffer(sg_dump_data,
> + sg_nents(sg_dump_data),
> + fw_error_dump->trans_ptr->data,
> + fw_error_dump->trans_ptr->len,
> + fw_error_dump->op_mode_len);
>
smatch pointed out that we check fw_error_dump->trans_ptr for NULL
earlier, and that is indeed correct afaict; I've sent you a fix
internally :)
johannes
