Michal Kazior <[email protected]> writes: > On 14 November 2016 at 17:33, Erik Stromdahl <[email protected]> wrote: >> Signed-off-by: Erik Stromdahl <[email protected]> >> --- >> drivers/net/wireless/ath/ath10k/htc.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/wireless/ath/ath10k/htc.h >> b/drivers/net/wireless/ath/ath10k/htc.h >> index 589800a..df16a04 100644 >> --- a/drivers/net/wireless/ath/ath10k/htc.h >> +++ b/drivers/net/wireless/ath/ath10k/htc.h >> @@ -62,6 +62,8 @@ enum ath10k_htc_rx_flags { >> ATH10K_HTC_FLAG_BUNDLE_MASK = 0xF0 >> }; >> >> +#define ATH10K_HTC_FLAG_BUNDLE_LSB 4 > > Just an idea - we could start using FIELD_GET() with > ATH10K_HTC_FLAG_BUNDLE_MASK alone. I would love to see Jakub's > bitfield stuff be used more. Kalle, thoughts?
Yeah, the bitfield macros are handy and we should definitely switch to them (slowly). But definitely not a must for these SDIO patches, more like a nice bonus. -- Kalle Valo
