On 15-11-2016 12:10, Kalle Valo wrote: > Gianfranco Costamagna <[email protected]> writes: > >>> Well, not before you pointed it out ;-). You are welcome to send a patch >>> fixing it. Otherwise, I will take care of it. >> >> attaching a format-patch like version. >> I don't think we need a Tested-by or whatever, because it is just a typo in >> a comment. >> (this is my first contribution, feel free to rebase or change whatever you >> prefer >> to make it in line with other styles) >> >> (I gave authorship to Marco, the first one who discovered such typo) > > [...] > >> Signed-off-by: Gianfranco Costamagna <[email protected]> >> Signed-off-by: Nicola Smaldone <[email protected]> >> Signed-off-by: Arlone Marco <[email protected]> > > Please note that you cannot add Signed-off-by for other people without > their explicit approval (see Documentation/SubmittingPatches). I don't > know if they did it in this case or not, but wanted to point out this > anyway.
Thanks, Kalle It was on my list to give a contrib boot camp here. So let's go over things here albeit it late. Hi Gianfrance, A couple of things from which you may benefit for future contributions. Basic info can be found in Documentation/SubmittingPatches as Kalle indicated. Patches should not be submitted as attachments. After doing 'git format-patch' the easiest way is using 'git send-email' (which requires you to have sendmail on your system properly setup). I tend to send patches to Kalle and Cc: linux-wireless, but that is my personal preference. Sending it to the list should be sufficient as patchwork will pick it up [1]. When it comes to attribution of others you should have their approval for Signed-off-by. However, reading your remarks it seems a proper way is below: Reported-by: Arlone Marco <[email protected]> Tested-by: Nicola Smaldone <[email protected]> Signed-off-by: Gianfranco Costamagna <[email protected]> Regards, Arend [1] https://patchwork.kernel.org/project/linux-wireless/list/
