Prameela Rani Garnepudi <[email protected]> writes: > Filtering the rx frames in firmware after connection in station mode > avoids the overhead of processing un-necessary frames. Hence rx filter > frame is added which can be configured to device at suitable times. > > Signed-off-by: Prameela Rani Garnepudi <[email protected]>
A minor nitpick about the patch title. As I slept through most of my english classes I don't know the correct terminology but the common style is to use form "rsi: add foo", not "rsi: added foo". > +/** > + * This function sends a frame to filter the RX packets > + * > + * @param common Pointer to the driver private structure. > + * @param rx_filter_word - Flags of filter packets > + * @return 0 on success, -1 on failure. > + */ > +int rsi_send_rx_filter_frame(struct rsi_common *common, u16 rx_filter_word) Based on Documentation/kernel-documentation.rst this doesn't look to be valid kernel-doc format. But AFAICS you got the format correct in patch 3. Also this function uses negative error codes (as preferred), it's not just -1 on failure. You should fix that in the comment (similar problems also elsewhere in this patchset). Personally I would not even bother adding kernel-docs for driver internal functions. It's a lot of work to maintain them and still they are quite often outdated, so people can't trust them and need to check from the source anyway. But if you like them feel free to continue adding them. -- Kalle Valo
