Re: [PATCH] nl80211: fix logic inversion in start_nan()

[Arend Van Spriel]

On 21-11-2016 13:55, Johannes Berg wrote:
> From: Johannes Berg <johannes.b...@intel.com>
> 
> Arend inadvertedly inverted the logic while converting to
> wdev_running(), fix that.

It was indeed inadvertedly.

Thanks,
Arend

> Fixes: 73c7da3dae1e ("cfg80211: add generic helper to check interface is 
> running")
> Signed-off-by: Johannes Berg <johannes.b...@intel.com>
> ---
>  net/wireless/nl80211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 4e9bda49e957..e4f718e956d7 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -10625,7 +10625,7 @@ static int nl80211_start_nan(struct sk_buff *skb, 
> struct genl_info *info)
>       if (wdev->iftype != NL80211_IFTYPE_NAN)
>               return -EOPNOTSUPP;
>  
> -     if (!wdev_running(wdev))
> +     if (wdev_running(wdev))
>               return -EEXIST;
>  
>       if (rfkill_blocked(rdev->rfkill))
>