Prameela Rani Garnepudi <[email protected]> writes:
> On 11/14/2016 05:45 PM, Prameela Rani Garnepudi wrote: >> Switch clock info values are changed in the firmware for both 20MHZ >> and 40MHZ modes. Hence these values which are configured through boot >> parameters request frame are updated. Also three other power save >> related parameters are added to boot up parameters. >> >> Signed-off-by: Prameela Rani Garnepudi <[email protected]> (Removed over hundred lines of unnecessary quotes, please edit your quotes.) > Can you please tell me, what modifications need to be done for this > patch. I already modified the code as per your previous suggestions. Like always, please check the patchwork before sending any emails. The patch in question is here: https://patchwork.kernel.org/patch/9427401/ It's in state "Changes Requested" which means that one of patches in the patchset should have some comments. After looking at the other patches I see my comment in patch 2: https://patchwork.kernel.org/patch/9427419/ "Based on Documentation/kernel-documentation.rst this doesn't look to be valid kernel-doc format. But AFAICS you got the format correct in patch 3. Also this function uses negative error codes (as preferred), it's not just -1 on failure. You should fix that in the comment (similar problems also elsewhere in this patchset)." -- Kalle Valo
