On 12/05/2016 06:54 AM, Johannes Berg wrote:
On Mon, 2016-12-05 at 06:47 -0800, Ben Greear wrote:
On 12/05/2016 05:59 AM, Johannes Berg wrote:
+static ssize_t misc_read(struct file *file, char __user *user_buf,
+ size_t count, loff_t *ppos)
+{
+ struct ieee80211_local *local = file->private_data;
+ size_t bufsz = 1000;
+ char *buf = kzalloc(bufsz, GFP_KERNEL);
You need at most IEEE80211_MAX_QUEUES * 16 (==256) which I think
you
can put on the stack?
I actually run with 64 queues in my tree,
Heh, well, in that case the 1000 is actually potentially too small for
you :) (it'll work because there never are many packets on the queues
though)
and either way, I thought large-ish things on the stack were frowned
upon for systems that want to run smaller stacks?
Yeah but the limit is more like 1KB :)
Maybe allocate, but actually do 16*NUM_QUEUES? The 1000 is just
arbitrarily magic in there.
Sounds good, I'll respin it.
Thanks,
Ben
johannes
--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com
