On 28 December 2016 at 21:39, Martin Blumenstingl <[email protected]> wrote: > On Wed, Dec 28, 2016 at 9:32 PM, Rafał Miłecki <[email protected]> wrote: >> On 28 December 2016 at 21:05, Arend van Spriel >> <[email protected]> wrote: >>> On 28-12-16 16:59, Rafał Miłecki wrote: >>>> From: Rafał Miłecki <[email protected]> >>>> >>>> This new file should be used for properties handled at higher level and >>>> so usable with all drivers. >>>> >>>> Signed-off-by: Rafał Miłecki <[email protected]> >>>> --- >>>> .../devicetree/bindings/net/wireless/ieee80211.txt | 16 >>>> ++++++++++++++++ >>>> 1 file changed, 16 insertions(+) >>>> create mode 100644 >>>> Documentation/devicetree/bindings/net/wireless/ieee80211.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.txt >>>> b/Documentation/devicetree/bindings/net/wireless/ieee80211.txt >>>> new file mode 100644 >>>> index 0000000..c762769 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.txt >>>> @@ -0,0 +1,16 @@ >>>> +Common IEEE 802.11 properties >>>> + >>>> +This provides documentation of common properties that are handled by a >>>> proper >>>> +net layer and don't require extra driver code. >>> >>> Please do not make any assumptions on how DT properties are handled nor >>> by what. Just state that these properties apply to all wireless devices >>> and are applicable to device specific bindings. >> >> OK, I'll try to improve this description. >> >> >>>> +Optional properties: >>>> + - ieee80211-min-center-freq : minimal supported frequency in KHz >>>> + - ieee80211-max-center-freq : maximal supported frequency in KHz >>>> + >>>> +Example: >>>> + >>>> +pcie@0,0 { >>>> + reg = <0x0000 0 0 0 0>; >>>> + ieee80211-min-center-freq = <2437000>; >>>> + ieee80211-max-center-freq = <2457000>; >>>> +}; >>> >>> Is this the proper level to define it. I was expecting a child node of >>> the pci(e) controller. Maybe I am misreading the example. >> >> This is device node, not a controller node (and yes, it's complete >> node). You just need to add such a node inside the controller one. > you should name the node wifi@0,0 instead. I revised my ath9k OF > binding documentation due to similar concerns (and after seeing the > result I must admit that they were right). you can have a look at the > result here: [0]
Thanks for your comment, I'm far from considering myself DT expert, so I often need help with such things, I'll change this in V2. -- Rafał
