Hi I looked more detail in the patches and now I think shared mem and 16 hw beacons patches are not needed. Explanation is below. Sorry for not pointing this before.
On Mon, Jan 16, 2017 at 04:01:14AM +0100, Daniel Golle wrote: > From: Gabor Juhos <[email protected]> > > On the RT3593 chipset, the beacon registers are located > in the high 8KB part of the shared memory. > > The high part of the shared memory is only accessible > if it is explicitly selected. Add a helper function > in order to be able to control the SHR_MSEL bit in > the PBF_SYS_CTRL register. Also add a few more helper > functions and use those to select the correct part of > the shared memory before and after accessing the beacon > registers. > > The base addresses of the beacon registers are also > different from the actually used values, so fix the > 'rt2800_hw_beacon_base' function to return the correct > values. > > Signed-off-by: Gabor Juhos <[email protected]> > Signed-off-by: Daniel Golle <[email protected]> <snip> > +static inline bool rt2800_beacon_uses_high_mem(struct rt2x00_dev *rt2x00dev) > +{ > + if (rt2x00_rt(rt2x00dev, RT3593)) > + return true; I just check that RT3593 (USB) device send beacon on AP mode when it is configured previous way. I believe on RT3883 old way of configuring beacons will work as well. This change is only needed if we have to configure more than 8 beacons i.e. add support to more than 8 APs per device. However there is no patch increasing number of supported AP to 16 (by changing max_ap_intf), so apparently nobody use this feature. Hence I believe shared mem and 16 hw beacons is not needed and I prefer to not add support for 16 APs per device with cost of adding this additional complexity to the driver. Stanislaw
