On Sat, 2017-01-07 at 04:43 -0500, Andrew Zaborowski wrote: > With the basic mac80211 implementation in my patch 4/4 this feature > should be set when IEEE80211_VIF_BEACON_FILTER is not set. The > problem with a nl80211_ext_feature is that it's per wiphy instead of > per interface. So in the case mac80211, it would need to be set if > all interfaces can accept lists of thresholds and that can change > dynamically as interfaces are added. And nl80211 has no per- > interface features.
Right - it doesn't even have that concept, and I'm not sure that really makes sense. > I wonder if it's better to add a ieee80211_hw_flags flag to advertise > this feature per wiphy, or, as an approximation, set the flag based > on the default interface that is created in ieee80211_register_hw. I think we should just leave the new flag up to the driver then. The only driver using per-interface beacon filtering (iwlwifi, afaik) will either need to convert to actually handle it in the beacon filtering case (which is the normal case anyway). johannes
