Re: [PATCH 06/10] rt2x00: fixup fill_tx_status for nomatch case

[Felix Fietkau]

On 2017-02-14 13:46, Stanislaw Gruszka wrote:
> Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com>
> ---
>  drivers/net/wireless/ralink/rt2x00/rt2x00dev.c   | 6 +++++-
>  drivers/net/wireless/ralink/rt2x00/rt2x00queue.h | 1 +
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c 
> b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c
> index 90fc259..258d94d 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c
> @@ -357,6 +357,9 @@ static void rt2x00lib_fill_tx_status(struct rt2x00_dev 
> *rt2x00dev,
>       if (i < (IEEE80211_TX_MAX_RATES - 1))
>               tx_info->status.rates[i].idx = -1; /* terminate */
>  
> +     if (!test_bit(TXDONE_ACK_REQ, &txdesc->flags))
> +             tx_info->flags |= IEEE80211_TX_CTL_NO_ACK;
> +
Since nothing sets TXDONE_ACK_REQ, this will probably create a regression.

- Felix