On 14-2-2017 14:12, Johannes Berg wrote:
> On Tue, 2017-02-14 at 14:07 +0100, Arend Van Spriel wrote:
>
>>> No. But there was a size limit on how much older userspace could
>>> process before we did the splitting.
>>
>> I see. So basically adding stuff to (split_start == 0) is not wanted.
>
> Correct.
Uhm. Now I am staring at the code there and wonder about following. Up
until (split_start == 7) I see:
state->split_start++;
if (state->split)
break;
For the remaining cases the break is unconditional. Any idea how to
interpret that?
>> Just trying to get a clear requirement/rule here. Do we (still) know
>> the exact size limit?
>
> No, I don't remember. It's pretty ancient versions of iw/wpa_s that
> weren't able to deal with it. There was also interaction with the
> allocations in the dump function in nl80211 code itself, but we made
> those pretty big already and userspace limits came into play iirc.
Thanks,
Arend
