> + msg_head = genlmsg_put(skb, 0, 0, &hwsim_genl_family, 0, > + HWSIM_CMD_NOTIFY);
I think you should use a more specific command name. > + if (nla_put(skb, HWSIM_ATTR_ADDR_TRANSMITTER, > + ETH_ALEN, data->addresses[1].addr)) > + goto nla_put_failure; and at least also add a more specific identifier like the radio ID. > + if (data->channel) > + center_freq = data->channel->center_freq; > + > + if (nla_put_u32(skb, HWSIM_ATTR_FREQ, center_freq)) > + goto nla_put_failure; and have the full channel definition Also the indentation in the documentation didn't match the convention used there. johannes
