From: Sven Eckelmann <[email protected]>

Board Data File (BDF) is loaded upon driver boot-up procedure. The right
board data file is identified on QCA4019 using bus, bmi-chip-id and
bmi-board-id.

The problem, however, can occur when the (default) board data file cannot
fulfill with the vendor requirements and it is necessary to use a different
board data file.

This problem was solved for SMBIOS by adding a special SMBIOS type 0xF8.
Something similar has to be provided for systems without SMBIOS but with
device trees. No solution was specified by QCA and therefore a new one has
to be found for ath10k.

The device tree requires addition strings to define the variant name

    wifi@a000000 {
        status = "okay";
        qcom,ath10k-calibration-variant = "RT-AC58U";
    };

    wifi@a800000 {
        status = "okay";
        qcom,ath10k-calibration-variant = "RT-AC58U";
    };

This would create the boarddata identifiers for the board-2.bin search

 *  bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=RT-AC58U
 *  bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=RT-AC58U

Cc: Waldemar Rymarkiewicz <[email protected]>
Signed-off-by: Sven Eckelmann <[email protected]>
---
Cc: Christian Lamparter <[email protected]>
Cc: John Crispin <[email protected]>
Cc: Simon Wunderlich <[email protected]>
---
 .../bindings/net/wireless/qcom,ath10k.txt          |  3 +++
 drivers/net/wireless/ath/ath10k/core.c             | 31 +++++++++++++++++++++-
 2 files changed, 33 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt 
b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
index 74d7f0af209c..60f87439308e 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
@@ -41,6 +41,9 @@ Optional properties:
 - qcom,msi_addr: MSI interrupt address.
 - qcom,msi_base: Base value to add before writing MSI data into
                MSI address register.
+- qcom,ath10k-calibration-variant: string to search for in the board-2.bin
+                                  variant list with the same bus bmi-chip-id,
+                                  and bmi-board-id
 - qcom,ath10k-calibration-data : calibration data + board specific data
                                 as an array, the length can vary between
                                 hw versions.
diff --git a/drivers/net/wireless/ath/ath10k/core.c 
b/drivers/net/wireless/ath/ath10k/core.c
index 0a8e29e9a0eb..6f4c7ccb0dba 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -779,6 +779,31 @@ static int ath10k_core_check_smbios(struct ath10k *ar)
        return 0;
 }
 
+static int ath10k_core_check_dt(struct ath10k *ar)
+{
+       struct device_node *node;
+       const char *variant;
+
+       /* don't overwrite the smbios entry */
+       if (ar->id.bdf_ext[0] != '\0')
+               return 0;
+
+       node = ar->dev->of_node;
+       if (!node)
+               return -ENOENT;
+
+       of_property_read_string(node, "qcom,ath10k-calibration-variant",
+                               &variant);
+       if (!variant) {
+               ath10k_dbg(ar, ATH10K_DBG_BOOT, "DT bdf variant name not 
found.\n");
+               return -ENODATA;
+       }
+
+       strscpy(ar->id.bdf_ext, variant, sizeof(ar->id.bdf_ext));
+
+       return 0;
+}
+
 static int ath10k_download_and_run_otp(struct ath10k *ar)
 {
        u32 result, address = ar->hw_params.patch_load_addr;
@@ -2221,7 +2246,11 @@ static int ath10k_core_probe_fw(struct ath10k *ar)
 
        ret = ath10k_core_check_smbios(ar);
        if (ret)
-               ath10k_dbg(ar, ATH10K_DBG_BOOT, "bdf variant name not set.\n");
+               ath10k_dbg(ar, ATH10K_DBG_BOOT, "SMBIOS bdf variant name not 
set.\n");
+
+       ret = ath10k_core_check_dt(ar);
+       if (ret)
+               ath10k_dbg(ar, ATH10K_DBG_BOOT, "DT bdf variant name not 
set.\n");
 
        ret = ath10k_core_fetch_board_file(ar);
        if (ret) {
-- 
2.11.0

Reply via email to