On 14-3-2017 23:19, Johannes Berg wrote: > On Tue, 2017-03-14 at 21:51 +0000, Arend van Spriel wrote: >> To support network namespace the driver must assure all created >> network interfaces are in the same namespace as the wiphy instance. > > FWIW, looks fine to me.
Thanks. Any feedback is worth something ;-) >> memcpy(ndev->dev_addr, ifp->mac_addr, ETH_ALEN); >> + wiphy = cfg_to_wiphy(drvr->config); >> + dev_net_set(ndev, wiphy_net(wiphy)); > > You (almost?) don't need the wiphy variable :) Yeah. I could wrap that into wiphy_net() call as it is the only place I need it. Will do that if I stay clear from column #80. Regards, Arend
