Hi Arend,

Overall this looks good, and I've almost applied it - but I have a
question on this patch.

You have this list:

> +     struct list_head sched_scan_req_list;

>       struct cfg80211_sched_scan_request __rcu *sched_scan_req;

but you kept this. In fact, it's even still *used*. I don't understand
that part.

Also, you used RCU primitives for the new list, but you never actually
used them - except in one place (in nl80211_stop_sched_scan) where it's
actually not needed at all and the _rcu should be removed (since it
holds the lock)

What's up with that?

johannes

Reply via email to